Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/a11y/use_button_type): skip the rule with spread attribute #2249

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

fireairforce
Copy link
Member

Summary

closes: #2248

Test Plan

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Mar 31, 2024
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit d088b7c
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66096de268641c000879d203
😎 Deploy Preview https://deploy-preview-2249--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 31, 2024

CodSpeed Performance Report

Merging #2249 will improve performances by 6.67%

⚠️ No base runs were found

Falling back to comparing fireairforce:fix-2248 (d088b7c) with main (d98c549)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main fireairforce:fix-2248 Change
db.json[cached] 74 ms 69.4 ms +6.67%

@Conaclos Conaclos merged commit b95cba5 into biomejs:main Mar 31, 2024
17 checks passed
@Conaclos
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/a11y/useButtonType doesn't know when type is spread
3 participants